Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve acs3 protocol #3566

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Improve acs3 protocol #3566

merged 5 commits into from
Jul 4, 2024

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented Jun 24, 2024

For issue: #3565

Copy link

vizipi bot commented Jun 24, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
72.73% ZhangXin 18 8
36.36% jason-hoopox 8 4
9.09% louis.li 2 1
9.09% 轩辕焮痕 2 1
9.09% zhifenglee-portkey 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.Contracts.Referendum.Tests/ReferendumContractTe83.33%10 out of 12 times
...test/AElf.Contracts.Parliament.Tests/ParliamentContractTe75.00%9 out of 12 times
...contract/AElf.Contracts.CrossChain/CrossChainContract_Hel66.67%8 out of 12 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs66.67%8 out of 12 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT66.67%8 out of 12 times
...test/AElf.Contracts.CrossChain.Tests/CrossChainContractTe66.67%8 out of 12 times
test/AElf.Contracts.TestBase/ContractTester.cs66.67%8 out of 12 times
contract/AElf.Contracts.CrossChain/CrossChainContract.cs66.67%8 out of 12 times
protobuf/acs7.proto66.67%8 out of 12 times
...test/AElf.Contracts.CrossChain.Tests/SideChainLifeTimeMan66.67%8 out of 12 times

Committed file ranks

(click to expand)
  • 90.83%[protobuf/association_contract.proto]
  • 95.97%[contract/AElf.Contracts.Referendum/Referendum.cs]
  • 96.44%[contract/AElf.Contracts.Parliament/Parliament.cs]
  • 96.04%[contract/AElf.Contracts.Referendum/Referendum_Helper.cs]
  • 92.59%[protobuf/parliament_contract.proto]
  • 88.57%[protobuf/referendum_contract.proto]
  • 96.04%[...test/AElf.Contracts.Association.Tests/AssociationContract]
  • 95.31%[contract/AElf.Contracts.Association/Association.cs]
  • 94.21%[contract/AElf.Contracts.Association/Association_Helper.cs]
  • 97.73%[protobuf/acs3.proto]
  • Copy link

    codecov bot commented Jun 24, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 90.72%. Comparing base (d766999) to head (e2d727b).

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3566      +/-   ##
    ==========================================
    + Coverage   90.70%   90.72%   +0.01%     
    ==========================================
      Files         668      668              
      Lines       25895    25941      +46     
      Branches     2325     2325              
    ==========================================
    + Hits        23489    23535      +46     
      Misses       2290     2290              
      Partials      116      116              
    Files Coverage Δ
    contract/AElf.Contracts.Association/Association.cs 80.97% <100.00%> (+0.16%) ⬆️
    ...t/AElf.Contracts.Association/Association_Helper.cs 96.99% <100.00%> (+0.27%) ⬆️
    contract/AElf.Contracts.Parliament/Parliament.cs 95.88% <100.00%> (+0.03%) ⬆️
    ...act/AElf.Contracts.Parliament/Parliament_Helper.cs 86.80% <100.00%> (+0.83%) ⬆️
    contract/AElf.Contracts.Referendum/Referendum.cs 98.85% <100.00%> (+0.01%) ⬆️
    ...act/AElf.Contracts.Referendum/Referendum_Helper.cs 98.83% <100.00%> (+0.11%) ⬆️

    @YueZh127
    Copy link
    Collaborator

    YueZh127 commented Jul 2, 2024

    Test complete, test scope:

    1. Before the upgrade, the proposal was queried through GetProposal without any errors
    2. After the upgrade, assigning a value to the title description can obtain the correct value through the transaction event
    3. Query proposal details correctly through GetProposal

    @eanzhao eanzhao merged commit 8dfa973 into dev Jul 4, 2024
    15 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants