Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong method fee free allowances for balance less than threshold #3361

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

jason-aelf
Copy link
Collaborator

Closes #3359

@vizipi
Copy link

vizipi bot commented Jan 18, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % EanCuznaivy 123 1
100.00 % weili 88 1
100.00 % Napoleon Wang 13 1
100.00 % kaiwenzhengaelf 5 1
100.00 % ssun0121 4 1
100.00 % wangyue 2 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/token_contract.proto40.97 %127 out of 310 times

Committed file ranks

(click to expand)
  • 99.94%[contract/AElf.Contracts.MultiToken/TokenContract_Fees.cs]
  • @codecov
    Copy link

    codecov bot commented Jan 18, 2023

    Codecov Report

    Merging #3361 (d94588f) into master (3906a55) will decrease coverage by 0.04%.
    The diff coverage is 66.66%.

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master    #3361      +/-   ##
    ==========================================
    - Coverage   91.05%   91.01%   -0.04%     
    ==========================================
      Files         619      619              
      Lines       23682    23684       +2     
      Branches     2093     2094       +1     
    ==========================================
    - Hits        21563    21557       -6     
    - Misses       1988     1996       +8     
      Partials      131      131              
    Impacted Files Coverage Δ
    ...ct/AElf.Contracts.MultiToken/TokenContract_Fees.cs 92.08% <66.66%> (-0.99%) ⬇️
    .../AElf.Contracts.MultiToken/TokenContract_Helper.cs 79.68% <0.00%> (-0.53%) ⬇️

    @jason-aelf jason-aelf merged commit 8d733b0 into master Jan 18, 2023
    @delete-merged-branch delete-merged-branch bot deleted the hotfix/method-fee-free-allowances branch January 18, 2023 06:42
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants