Fix economic system bugs. #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time.
Committed file ranks |
Codecov Report
@@ Coverage Diff @@
## dev #1705 +/- ##
==========================================
- Coverage 74.46% 52.4% -22.06%
==========================================
Files 407 241 -166
Lines 18735 8964 -9771
==========================================
- Hits 13951 4698 -9253
+ Misses 4784 4266 -518
|
Codecov Report
@@ Coverage Diff @@
## dev #1705 +/- ##
=========================================
- Coverage 80.8% 39.3% -41.51%
=========================================
Files 407 312 -95
Lines 18735 14571 -4164
=========================================
- Hits 15139 5727 -9412
- Misses 3596 8844 +5248
|
Maybe this should according to date, like every July 1st we increase 2 miners.AElf/src/AElf.Contracts.Consensus.AEDPoS/ViewMethods.cs Lines 626 to 631 in d0b47a7 This comment was generated by todo based on a
|
|
❌ Build AElf 1.0.0.1799 failed (commit e629851498 by @EanCuznaivy) |
|
❌ Build AElf 1.0.0.1803 failed (commit bb1855c5d8 by @EanCuznaivy) |
rosona
reviewed
May 15, 2019
| ProfitsAmount = input.Amount, | ||
| IsReleased = true | ||
| }; | ||
| } | ||
| else | ||
| { | ||
| releasedProfitInformation.TotalWeight = profitItem.TotalWeight; | ||
| releasedProfitInformation.TotalWeight = totalWeight; | ||
| releasedProfitInformation.ProfitsAmount += input.Amount; |
rosona
approved these changes
May 15, 2019
shiwk
approved these changes
May 15, 2019
loning
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.