Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why ScreenManager.AskInvisible returns a new NetworkCredential("", pwd).Password;? #296

Closed
reyoung opened this issue Jul 9, 2018 · 1 comment
Closed

Why ScreenManager.AskInvisible returns a new NetworkCredential("", pwd).Password;? #296

reyoung opened this issue Jul 9, 2018 · 1 comment
Assignees
@EricBlack
Labels
enhancement Used to propose an enhancement to some existing code or module
Milestone
Dev-ecosystem

Comments

@reyoung
Copy link

reyoung commented Jul 9, 2018 •
edited
Loading

The related code is here. I do not understand why here returns a new NetworkCredential("", pwd).Password; instead of just pwd.

AElf/AElf.CLI/Screen/ScreenManager.cs

Lines 287 to 289 in e6a9e1a

return new NetworkCredential("", pwd).Password;
}

Is it because we want to use SecureString? Should we just return SecureString in the method AskInvisible?
@rosona rosona added the enhancement Used to propose an enhancement to some existing code or module label Sep 19, 2018
@rosona rosona added the backlog label Dec 7, 2018
rosona added a commit that referenced this issue Dec 27, 2018
@rosona
Fix issue #296, replace NetworkCredential lib to get plain password
cb86645
@rosona rosona assigned rosona and unassigned samfrb Dec 27, 2018
@rosona rosona added this to the Dev-ecosystem milestone Dec 27, 2018
@rosona rosona added review and removed backlog labels Dec 27, 2018
@rosona rosona assigned EricBlack and unassigned rosona Dec 27, 2018
@EricBlack
Copy link
Contributor

Close due to fixed.

@ghost ghost removed the review label Dec 28, 2018
rosona added a commit that referenced this issue Dec 28, 2018
@rosona
Merge pull request #753 from AElfProject/enhancement-code-quality-dev
e80a036 
Fix issue #296 & remove unused lib
loning added a commit that referenced this issue Dec 28, 2018
@loning
Merge branch 'dev' into release/0.7.0
5a91715 
* dev: (41 commits)
  fix issue 709
  Fix unit test
  On remove peer remove all disposed.
  Fix bug different transaction execution result between mining and block execution process.
  Fix testcase error
  Remove unused reference lib
  Fix issue #296, replace NetworkCredential lib to get plain password
  Fix bug side chain disposal.
  [Feature] Get current miners in ElectionInfo.
  Support LIB event in miner lifetime test case.
  fix bug CheckAuthority exception
  update js sdk module
  Simplify miner structure.
  Add current block time in execution context.
  Align TransactionResult in BlockExecutor
  fix bug chain id format
  ClaimTransactionFees send fees to FeePoolAddress instead of the sender's address
  Fix withTransaction parameter
  Fix null ChainService
  Don't insert ClaimFees transaction if we are in unit test
  ...

# Conflicts:
#	AElf.ABI.CSharp.Tests/ABITest.cs
#	AElf.ABI.CSharp.Tests/AElf.ABI.CSharp.Tests.csproj
#	AElf.Benchmark/BenchmarkTps.cs
#	AElf.Benchmark/TransactionDataGenerator.cs
#	AElf.ChainController/BlockValidation/Filters/ConsensusValidationFilter.cs
#	AElf.Contracts.Authorization.Tests/AuthorizationTest.cs
#	AElf.Contracts.Authorization.Tests/MockSetup.cs
#	AElf.Contracts.Consensus.Tests/AElf.Contracts.Consensus.Tests.csproj
#	AElf.Contracts.Consensus.Tests/MockSetup.cs
#	AElf.Contracts.Genesis.Tests/AElf.Contracts.Genesis.Tests.csproj
#	AElf.Contracts.Genesis.Tests/ContractZeroTest.cs
#	AElf.Contracts.Genesis.Tests/MockSetup.cs
#	AElf.Contracts.Genesis.Tests/TestContractShim.cs
#	AElf.Contracts.SideChain.Tests/AElf.Contracts.SideChain.Tests.csproj
#	AElf.Contracts.SideChain.Tests/MockSetup.cs
#	AElf.Contracts.Token.Tests/AElf.Contracts.Token.Tests.csproj
#	AElf.Contracts.Token.Tests/ContractZeroShim.cs
#	AElf.Contracts.Token.Tests/MockSetup.cs
#	AElf.Contracts.Token.Tests/TokenContractTest.cs
#	AElf.Contracts.Token/TokenContract.cs
#	AElf.Execution/AElf.Execution.csproj
#	AElf.Execution/ParallelTransactionExecutingService.cs
#	AElf.Kernel.Tests/AElf.Kernel.Tests.csproj
#	AElf.Kernel.Tests/Concurrency/Metadata/ChainFunctionMetadataTest.cs
#	AElf.Kernel.Tests/ContractCodes.cs
#	AElf.Kernel.Tests/SmartContractExecuting/ContractTest.cs
#	AElf.Kernel/AElf.Kernel.csproj
#	AElf.Kernel/Chain/BlockChain.cs
#	AElf.Kernel/Chain/ChainService.cs
#	AElf.Launcher/AElf.Launcher.csproj
#	AElf.Miner.Rpc/Client/ClientBase.cs
#	AElf.Miner.Rpc/Client/ClientToParentChain.cs
#	AElf.Miner.Rpc/Server/ParentChainHeaderInfoRpcServer.cs
#	AElf.Miner.Rpc/Server/SideChainHeaderInfoRpcServer.cs
#	AElf.Miner.Tests/ContractCodes.cs
#	AElf.Miner.Tests/MinerLifetimeTests.cs
#	AElf.Miner.Tests/MockSetup.cs
#	AElf.Miner/Miner/Miner.cs
#	AElf.Miner/TxMemPool/TxHub.cs
#	AElf.Network/Peers/Peer.Sync.cs
#	AElf.Network/Peers/PeerManager.cs
#	AElf.Node/AElfChain/MainchainNodeService.cs
#	AElf.Node/NodeAElfModule.cs
#	AElf.RPC/AElf.RPC.csproj
#	AElf.Runtime.CSharp.Tests/AElf.Runtime.CSharp.Tests.csproj
#	AElf.Runtime.CSharp.Tests/MockSetup.cs
#	AElf.Sdk.CSharp.Tests/AElf.Sdk.CSharp.Tests.csproj
#	AElf.Sdk.CSharp.Tests/TestContractShim.cs
#	AElf.Synchronization/BlockExecution/BlockExecutor.cs
loning added a commit that referenced this issue Dec 28, 2018
@loning
Merge branch 'release/0.7.0' into feature/configuration-20181226
4460538 
* release/0.7.0: (44 commits)
  log4net fix a Redis configuration error
  fix issue 709
  add log4net for logging
  Fix unit test
  On remove peer remove all disposed.
  Fix bug different transaction execution result between mining and block execution process.
  Fix testcase error
  Remove unused reference lib
  fix build error
  Fix issue #296, replace NetworkCredential lib to get plain password
  Fix bug side chain disposal.
  [Feature] Get current miners in ElectionInfo.
  Support LIB event in miner lifetime test case.
  fix bug CheckAuthority exception
  update js sdk module
  Simplify miner structure.
  Add current block time in execution context.
  Align TransactionResult in BlockExecutor
  fix bug chain id format
  ClaimTransactionFees send fees to FeePoolAddress instead of the sender's address
  ...

# Conflicts:
#	AElf.Database/DatabaseAElfModule.cs
#	AElf.Kernel.Types/Transaction/TransactionTypeExtension.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricBlack EricBlack

Labels
enhancement Used to propose an enhancement to some existing code or module
Projects
None yet
Milestone
Dev-ecosystem
Development

No branches or pull requests
4 participants
@reyoung @EricBlack @rosona @samfrb