-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate dual funding by default #2825
Conversation
6fbded7
to
50f4646
Compare
And update the release notes.
50f4646
to
8848dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just a few nits/typos in the release notes.
I couldn't find the explanation of the switch in MinimalNodeFixture
from DummyOnChainWallet
to SingleKeyOnChainWallet
.
I can see that tests fail without that change, but some more information about the switch would make that change easier to review.
- clarify wording around activation - link to sample plugin
Right, that's because the The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2825 +/- ##
==========================================
- Coverage 85.99% 85.93% -0.06%
==========================================
Files 219 219
Lines 18453 18453
Branches 766 766
==========================================
- Hits 15869 15858 -11
- Misses 2584 2595 +11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready to go.
And update the release notes.