Add PeerReadyNotifier actor
#2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4048d86 to
ea3f097
Compare
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
- Coverage 84.99% 84.89% -0.10%
==========================================
Files 199 200 +1
Lines 15801 15884 +83
Branches 666 681 +15
==========================================
+ Hits 13430 13485 +55
- Misses 2371 2399 +28
|
We add an actor that waits for a given peer to be connected and ready to process payments. This is useful in the context of async payments for the receiver's LSP.
ea3f097 to
ffd49aa
Compare
remyers
reviewed
Dec 5, 2022
eclair-core/src/main/scala/fr/acinq/eclair/io/PeerReadyNotifier.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/io/PeerReadyNotifierSpec.scala
Show resolved
Hide resolved
If the peer disconnects while we're waiting for channel states, we should go back to wiating for them to connect. We also should avoid creating too many channel state collectors, we only need to keep the last one.
remyers
approved these changes
Dec 8, 2022
pm47
approved these changes
Dec 21, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an actor that waits for a given peer to be connected and ready to process payments.
This is useful in the context of async payments for the receiver's LSP.
@remyers you can start building the mechanism to trigger a pending async payment on top of that branch.