Feature/row rebase #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add csrfQuery to other providers/header * add more aggressive getCSRF queries * move CSRFQuery to userRTK * fix Explorer Application crash * v0.10.23 --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu>
Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu>
* add ErrorCard simplify guppyFetcher * use appInitialProps Update documnentation Fix cohort filters remove bug * tighten layout of QueryExpression * remove bad import * Update homepage documentation * Updated Styling documentation * updated package.json version number * v0.10.29
* Change header and all colors to light blue (includes globals like navbar but also exploration and profile page) * Text w/ blue background in all white or all black (buttons, header, etc) * Change fonts to match backgrounds * Remove ‘Link Account from External Data Resources’ * Resources should be collapsed by default
quinnwai
requested changes
Jun 14, 2024
| NavPageLayout, | ||
| NavPageLayoutProps, | ||
| getNavPageLayoutPropsFromConfig, | ||
| } from '@gen3/frontend'; |
There was a problem hiding this comment.
do you want to keep only the changes from the original page since this is ours? It might be good to put this in the sampleCommons in the future so it doesn't get touched? Idk why it's being edited
| GEN3_COMMONS_NAME=gen3 |
| "accessibleValidationField": "project_id" | ||
| } | ||
| }, | ||
| { | ||
| "tabTitle": "Observation", | ||
| "charts": { | ||
| "project_id": { | ||
| "chartType": "fullPie", | ||
| "chartType": "donut", |
There was a problem hiding this comment.
might need to resolve some of these and keep our changes for this file... not sure which is which here
| @@ -26,6 +18,23 @@ | |||
| "linkType": "portal", | |||
| "text": "Explore Gen3 Data" | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
Do we wanna just checkout our old SampleCommons/config/cbds? Unless you think Craig messed with it at all (prolly didn't)
|
LGTM |
quinnwai
added a commit
that referenced
this pull request
Dec 6, 2024
* update configs * make image buildable * fix build error * update columns and facets to recent data (11/25/24) * update reports and fix facet titles --------- Co-authored-by: quinnwai <quinnwai.wong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.