Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datestamps in pointer filenames configurable #9

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

anton-seaice
Copy link
Collaborator

@anton-seaice anton-seaice commented Dec 16, 2024

This adds support in cice for the addition of datestamps to the pointer filenames to be configured through the nuopc option restart_pointer_append_date .

Contributes to COSIMA/access-om3#237

@anton-seaice anton-seaice changed the title Make datestemps in pointer filenames configurable Make datestamps in pointer filenames configurable Jan 14, 2025
@anton-seaice anton-seaice marked this pull request as ready for review January 14, 2025 02:29
@anton-seaice
Copy link
Collaborator Author

anton-seaice commented Jan 14, 2025

Hi @chrisb13 and @aekiss

This is needed to finalise the updated CICE version. So is a companion to COSIMA/access-om3#250, where the same change is needed, see nuopc_shr_methods.F90.patch

Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Copy link

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small suggestions

Copy link

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice. Currently, if a user sets restart_pointer_append_date without CESMCOUPLED it will have no effect. See my suggested change to fix this below.

cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90 Outdated Show resolved Hide resolved
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
@anton-seaice anton-seaice merged commit e68e05b into main Jan 24, 2025
1 check passed
@anton-seaice anton-seaice deleted the 237-rpointer branch January 24, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants