Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOM supergrid #8

Merged
merged 2 commits into from
Dec 11, 2024
Merged

MOM supergrid #8

merged 2 commits into from
Dec 11, 2024

Conversation

anton-seaice
Copy link
Collaborator

Add implementation for CICE to read the mom supergrid file directly, and use this as the grid file.

This is the same as CICE-Consortium#993 but that will take a while to get through review etc.

Closes #7

I am not sure how to review this, it will get review in the CICE-consortium PR. I am not sure we also need to review it. The upstream PR has details to the testing and comparisons done.

@anton-seaice anton-seaice self-assigned this Dec 6, 2024
Comment on lines 136 to 137
and regional grids). The *mom_mosaic* code reads grids for a nonuniform grid defined
in the mom mosaic (supergrid) format.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there an objection in CICE-Consortium#993 to the term "mosaic"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks


if (l_readCenter) then
out_of_range = .false.
where (ANGLET < -pi .or. ANGLET > pi) out_of_range = .true.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could convert out-of-range values to in-range with cunning use of modulo? Or will this basically never happen?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what this check is protecting against, it may only be bad input data? I just implemented in the same for ANGLET as for ANGLE for consistency.

Copy link

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this only a cursory look-over, but it looks great and I'm happy to approve since this is an interim measure and will be reviewed more carefully upstream.

Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
@anton-seaice
Copy link
Collaborator Author

Thanks @aekiss

@anton-seaice anton-seaice merged commit 5aa8073 into main Dec 11, 2024
1 check passed
@anton-seaice anton-seaice deleted the 7-mom_supergrid_squashed branch December 11, 2024 03:22
anton-seaice added a commit that referenced this pull request Dec 20, 2024
* Read MOM supergrid file directly as grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOM supergrid implementation
2 participants