-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOM supergrid #8
Conversation
and regional grids). The *mom_mosaic* code reads grids for a nonuniform grid defined | ||
in the mom mosaic (supergrid) format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there an objection in CICE-Consortium#993 to the term "mosaic"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops thanks
|
||
if (l_readCenter) then | ||
out_of_range = .false. | ||
where (ANGLET < -pi .or. ANGLET > pi) out_of_range = .true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could convert out-of-range values to in-range with cunning use of modulo? Or will this basically never happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure what this check is protecting against, it may only be bad input data? I just implemented in the same for ANGLET as for ANGLE for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this only a cursory look-over, but it looks great and I'm happy to approve since this is an interim measure and will be reviewed more carefully upstream.
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Thanks @aekiss |
* Read MOM supergrid file directly as grid
Add implementation for CICE to read the mom supergrid file directly, and use this as the grid file.
This is the same as CICE-Consortium#993 but that will take a while to get through review etc.
Closes #7
I am not sure how to review this, it will get review in the CICE-consortium PR. I am not sure we also need to review it. The upstream PR has details to the testing and comparisons done.