Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spack.yaml: remove hash from SBR projection #6

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

harshula
Copy link
Collaborator

The top level SBR/MODEL's modulefile name should not have a hash.

@harshula harshula requested a review from CodeGat November 14, 2024 23:19
@harshula harshula self-assigned this Nov 14, 2024
Copy link

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@harshula harshula force-pushed the remove-hash-from-sbr-projection branch from 497dae7 to 064cd07 Compare November 14, 2024 23:21
Copy link

🚀 Deploying access-test 2024.11.15 as prerelease pr6-1

Details and usage instructions

This access-test model will be deployed as:

  • 2024.11.15 as a Release (when merged).
  • pr6-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-test/pr6-1

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-test- environment.

🛠️ Using: spack 0.22, spack-packages 2024.09.20, spack-config 2024.11.11

Details

It will be deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2024.09.20
  • access-nri/spack-config version 2024.11.11

If this is not what was expected, commit changes to config/versions.json.

Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Lets just await the rest of the checks, just to be sure.

@harshula harshula merged commit 4061242 into main Nov 14, 2024
11 checks passed
@harshula harshula deleted the remove-hash-from-sbr-projection branch November 14, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants