fix null pointer error when saving flutter widget #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user does not define an iOS groupId, the plugin fails to save any flutter widget into storage resulting in `(Failed to save screenshot to app group container: Null check operator used on a null value)`
ABausG
reviewed
Nov 21, 2023
ABausG
approved these changes
Dec 2, 2023
ABausG
reviewed
Dec 2, 2023
ABausG
approved these changes
Dec 2, 2023
|
Might need to rebase/fix the conflicts by the PR as the new flutter changes was also merged by you in (18cb7c7) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 68 67 -1
=========================================
- Hits 68 67 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for renderFlutterWidget
Relevant issue comments that provide what the exception was:
#91 (comment)
#91 (comment)
The issue happens if the user tries to save a flutter widget data into storage and hasn't defined any groupID for iOS. The null pointer exception occurred because the code checks for a null value. Hence, throwing the exception.
So we added a platform check for both iOS and Android and assigned value based on the active platform.