88 bugfix dashbord block homework sorting #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dk1080
requested changes
Nov 26, 2024
|
As mentioned.... the timebutton does not have any eventlisteners applied to them, since the eventlistener is created during the initialization of the page instead. This issue causes the timebutton to not have any functionality after filtering or sorting them. As written, this should be fixed in a future issue. |
Dk1080
approved these changes
Nov 26, 2024
|
Sorry about that. The functionality of code works and the code is well written. Good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timebutton now shows when homework is sorted on the block/homework feed on the dashboard.
Fixed by creating the correct html elements in sort.js and altering the data sent to the client.
Also added some attributes in filter.js to match the expected attributes of the timebutton.
The eventlistener created by clickInfo.js is not applied for these buttons and should be worked on in the future 👯