Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

31 homework student feature pretify the preparation feed #69

Merged

Conversation

Not-Brundle
Copy link
Contributor

No description provided.

Made changes so that the feed looks more like the wireframe.
Date and files ignored, because they are not working yet and make it look weird.
Fixed bug that position of infobox to be relative to outer-box.
Made some visual changes.
Merged main into branch.
add missing spaces
add linebreak
remove stray linebreak
cursor is not necessary
color is not necessary
remove unecessary font size
@Not-Brundle Not-Brundle linked an issue Nov 21, 2024 that may be closed by this pull request
@Not-Brundle Not-Brundle requested a review from Skjodt November 22, 2024 03:47
Copy link
Contributor

@Skjodt Skjodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husk at tilføje et billede som vi har aftalt til PO møderne, da jeg har ingen mulighed for at se, hvad jeg skal forvente. Fik nedenstående billede så går ud fra at det er det? Kan I bekræfte?

image

@Not-Brundle
Copy link
Contributor Author

Not-Brundle commented Nov 25, 2024

Dette er det jeg har lavet det udfra. På det tidspunkt eksisterede filter knapperne og time knappen ikke. Men det billede du har ser rigtigt ud.
HomeFeed

@Skjodt
Copy link
Contributor

Skjodt commented Nov 26, 2024

Dette er det jeg har lavet det udfra. På det tidspunkt eksisterede filter knapperne og time knappen ikke. Men det billede du har ser rigtigt ud. HomeFeed

Den henter slet ikke homework files, så tænker I skal have merged main ind, når jeres branch (PDF-word-count-reader-with-new-database) er merged i main

Copy link
Contributor

@Skjodt Skjodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Læs tidligere besked

@Not-Brundle
Copy link
Contributor Author

Burde virke nu.
homeworkfeed2

@Not-Brundle Not-Brundle requested a review from Skjodt November 28, 2024 08:56
@Not-Brundle Not-Brundle merged commit 7357e6e into main Nov 28, 2024
3 of 5 checks passed
@Not-Brundle Not-Brundle deleted the 31-homework-student-feature-pretify-the-preparation-feed branch November 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Homework-Student-Feature] Pretify the preparation feed
2 participants