Fix/add -- Code better follows MVSC pattern and addition of repository pattern #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeKahy
approved these changes
Dec 4, 2024
Laczse
approved these changes
Dec 4, 2024
…saving type to db, as that had been lost through merge
ChristofferGamel
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code now follows the actual structure of the MVSC pattern, where the code only calls the service which in turn calls the model.
The repository pattern has also been added as part of the model layer, as of now it is a partial integration to show the idea, a more thorough version is likely to spawn.
What is added/changed/removed
Some files for repositories have been added,
Changed where code calls the model directly instead of the service.
Testing
Runit, beit, sniffit
Checks