-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model aria better #2
Conversation
import widgetRole from './abstract/widgetRole'; | ||
import windowRole from './abstract/windowRole'; | ||
|
||
const ariaLiteralRoles = new Map([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ariaLiteralRoles/ariaAbstractRoles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gave this a cursory look through, will follow up with heavier review in a bit...these changes look awesome thank you for doing this!! looking forward to seeing what this project can turn into
import docTipRole from './dpub/docTipRole'; | ||
import docTocRole from './dpub/docTocRole'; | ||
|
||
const ariaLiteralRoles = new Map([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ariaLiteralRoles/ariaDpubRoles
flow/roles.js
Outdated
relatedConcepts: Array<RoleRelation>, | ||
requiredProps: Array<string>, | ||
requiredProps: {[key: string]: mixed}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments and docs clarifying these properties would be helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Righteo, can do.
…ently cannot handle
Added commentary and tighter Flow type definitions. The goal here is to get them defined down to individual properties and then move all the typing into https://github.com/flowtype/flow-typed |
No description provided.