Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model aria better #2

Merged
merged 15 commits into from
Mar 11, 2017
Merged

Model aria better #2

merged 15 commits into from
Mar 11, 2017

Conversation

jessebeach
Copy link
Member

No description provided.

import widgetRole from './abstract/widgetRole';
import windowRole from './abstract/windowRole';

const ariaLiteralRoles = new Map([
Copy link

@beefancohen beefancohen Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ariaLiteralRoles/ariaAbstractRoles

Copy link

@beefancohen beefancohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave this a cursory look through, will follow up with heavier review in a bit...these changes look awesome thank you for doing this!! looking forward to seeing what this project can turn into

import docTipRole from './dpub/docTipRole';
import docTocRole from './dpub/docTocRole';

const ariaLiteralRoles = new Map([

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ariaLiteralRoles/ariaDpubRoles

flow/roles.js Outdated
relatedConcepts: Array<RoleRelation>,
requiredProps: Array<string>,
requiredProps: {[key: string]: mixed},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments and docs clarifying these properties would be helpful!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Righteo, can do.

@jessebeach
Copy link
Member Author

Added commentary and tighter Flow type definitions. The goal here is to get them defined down to individual properties and then move all the typing into https://github.com/flowtype/flow-typed

@jessebeach jessebeach merged commit 95edfa3 into master Mar 11, 2017
@jessebeach jessebeach deleted the model-aria-better branch March 11, 2017 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants