Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CSP header example, backported from PR #884 #891

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

ghiscoding
Copy link
Collaborator

backport PR #884 from master branch into version4 branch

- to further improve CSP support for issue #878, we need to move `innerHTML` as separate assignment and not use it directly within a `createDomElement`, so for example this line `const elm = createDomElement('div', { innerHTML: '' })` should be split in 2 lines `const elm = createDomElement('div'); elm.innerHTML = '';`
@ghiscoding ghiscoding changed the title chore: backpost PR #884 add CSP header example chore: add CSP header example, backported from PR #884 Oct 30, 2023
@ghiscoding ghiscoding merged commit e722456 into version4 Oct 30, 2023
2 checks passed
@ghiscoding ghiscoding deleted the feat/v4-csp-header branch October 30, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants