-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Drop jQuery requirement #734
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
3df8a00
Drop jQuery requirement
MarkoBL 054f05b
- removed jQuery from slick.groupitemmetadataprovider.js
MarkoBL 7f56bdf
Rebase
MarkoBL 897ae9f
- removed jQuery from slick.groupitemmetadataprovider.js
MarkoBL c10a9a1
fixed tests: example-checkbox-header-row.spec.js,
MarkoBL 34cdfbc
fix test: example-composite-editor-modal-dialog.spec.js
MarkoBL 79e8efc
fix test: example-composite-editor-modal-dialog.spec.js
MarkoBL 29d9afa
moved slideUp/slideDown into Slick.Utils
MarkoBL afafcaa
Fixed Utils.position
MarkoBL 5481602
Switched from mouseenter/mouseleave to mouseover/mouseout
MarkoBL 4ce5e54
Use mouseenter/mouseleave on header and headerRow again, fixes test: …
MarkoBL b8436e9
Reworked EventData, fixed Drag and Drop, fixes test example-row-detai…
MarkoBL 59ba584
fixed updateColumnHeader(), fixes test: example-draggable-grouping.sp…
MarkoBL 0a8e2ab
fixed scrollTop/scrollLeft
MarkoBL cd517e3
Fixed Grid.ensureCellNodesInRowsCache, and other drag and drop relate…
MarkoBL a3b1603
fixed grid.getMaxSupportedCssHeight
MarkoBL a9e073b
some fixes
MarkoBL 11ef8ae
Revert vscode tasks.json
MarkoBL 6f7ba1c
fixing _footerRow exception
MarkoBL 3451b55
Removed TreeColumns and unused variables
MarkoBL 8fd7bd5
Revert "Removed TreeColumns and unused variables"
MarkoBL a899f70
Merge branch '6pac:master' into no-jquery
MarkoBL 008ed88
PATCH: ensure frozen options are set before render. Fixes #727
6pac ae37d3c
Merge branch '6pac:master' into no-jquery
MarkoBL f711c24
Curly braces and other small changes requested by @ghiscoding
MarkoBL c5a8c25
Even more curly braces :)
MarkoBL def1727
fixed events
MarkoBL 5367e73
ES5 syntax
MarkoBL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix test: example-composite-editor-modal-dialog.spec.js
- Loading branch information
commit 34cdfbcad13c28b23b8cba5f2f3a7142a9e87855
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
deep
default property is wrong, it should be set tofalse
since that would follow more closelyjQuery.extend()
and not cause surprises (and possibly breaking change) that I found myself. I found this to be a problem when in my own Slickgrid-Universal lib in which column filters were not showing up when they should be. Basically, the following code in SlickGrid should not be deep copied (the 1st argument is{}
and in jQuery simply mean merge the 2 next arguments or assign to a new object{}
when undefined)is supposed to be a shallow copy (work as a pointer), however because of this
deep = true
, it actually became a deep copy and is causing issues in my lib because my lib assume these column copies are shallow copy and not deep copy. After changing default todeep = false
, that would also follow more closely the NodeJS implementation in external 3rd party lib node.extendhttps://github.com/dreamerslab/node.extend/blob/62adee3327630c83f3d39395f7e275bfba281ecc/lib/extend.js#L47-L55