Feature & Trait Choices

[Wyzards]

What does this do?

• Replaces Feature's group attribute with the parent attribute. Its type is APIReference, and it points to the parent feature.
• Moves Feature's choice attribute into Feature's feature_specific attribute. Also renames it (either to subfeature_options, expertise_options, spell_options or trait_options for trait equivalents.
• Changes choice type of rogue-choose-expertise and bard-choose-expertise to proficiency.
• Removes unnecessary bard and rogue expertise features.
• Adds a choice structure to the trait draconic_ancestry's feature specific. Also includes draconic_ancestry's damage type and breath weapon action under trait_specific
• Removes "Choose: " from the name of Features which involve making a choice.
• removes "choose-" and "-choose" from traits / features whos index includes it.

These changes were discussed in the API Discord between myself and @fergcb with some input from @bagelbits and @ogregoire in a different draft PR.

Discord discussion link: https://discord.com/channels/656547667601653787/656547667601653790/861810226541625395
Old draft PR link: #378

How was it tested?

Database was run locally on machine. Was built from remote git branch and ran tests according to api documentation (unit test, integration and controllers).

Is there a Github issue this is resolving?

No.

Did you update the docs in the API? Please link an associated PR if applicable.

Yes, 5e-bits/5e-srd-api#226

Here's a fun image for your troubles

[ogregoire]

This is good, and it was well needed. Your correction regarding the previous PR is accurate and makes the naming more consistent regarding previous changes (removing "Choose:" rather than adding it, even though we should go further on that topic). I no longer want this PR to be split into several different as it does two things but does them well.

Since the PR is in draft mode, I cannot approve it in the GitHub sense of it, but I'm approving it here in written.

Given the large amount of commits, I believe that this PR should be squash-merged. What's your opinion on this?

[fergcb]

Given the large amount of commits, I believe that this PR should be squash-merged. What's your opinion on this?

All multi-commit PRs in this repo are squashed by default, anyway, are they not?

[bagelbits]

All multi-commit PRs in this repo are squashed by default, anyway, are they not?

@fergcb @ogregoire That is correct. All PRs are Squash and Merge. It makes it easy to rollback/revert for both repos if something goes wrong.

[bagelbits]

Double approve since @ogregoire approved it too.