backport dexterity copy flag patch. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '</configure>', | ||
| context=configurationContext) | ||
|
|
||
| def setUpPloneSite(self, portal): | ||
| pass | ||
| z2.installProduct(app, 'ftw.copymovepatches') |
There was a problem hiding this comment.
@maethu seems you've removed that? the initialize method is still there. Should we remove both or keep both?
6d2b05a to
75262c9
Compare
| xmlns="http://namespaces.zope.org/zope" | ||
| xmlns:genericsetup="http://namespaces.zope.org/genericsetup" | ||
| xmlns:i18n="http://namespaces.zope.org/i18n" | ||
| i18n_domain="bl.web"> |
75262c9 to
3df04c1
Compare
| i18n_domain="bl.web"> | ||
|
|
||
| <genericsetup:registerProfile | ||
| title="bl.web.tests" |
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
3df04c1 to
4dc42bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When copying a DX container which has AT children, the UID of the AT
children was not updated.
The reason for the error is that the DX container copy did not have the
_v_is_cpflag while the AT children were processed and thus the flagwas not properly delegated.
Solution:
By copying the
_v_is_cpand_v_cp_refs flagsto the copy we have thesame behavior as it used to be with AT, which does fix the error.