Make sentry init more configurable #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RychenerLorenz
approved these changes
Oct 30, 2023
bierik
approved these changes
Oct 31, 2023
deiferni
commented
Oct 31, 2023
- Provide some more defaults values - Allow to override default easily with dynamic values from factory methods - Unfortunately this seems necessary as overriding them with an `@property` does not work correctly when the attributes are accessed without an instance of the class, e.g. inside `@classmethod` - Provide option to override init kwargs
6f80678 to
072f19a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@propertydoes not work correctly when the attributes are accessed without an instance of the class, e.g. inside@classmethodOverrides can be seen in https://github.com/4teamwork/ris/pull/3236/files