Merge pull request #293 from /issues/292-no-excep-on-stub-missing

Issues/292 no excep on stub missing
4finance · Mar 1, 2015 · b9ffa6f · b9ffa6f
2 parents 719a2a4 + bad9063
commit b9ffa6f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/stub-runner/stub-runner/src/main/groovy/com/ofg/stub/StubDownloader.groovy b/stub-runner/stub-runner/src/main/groovy/com/ofg/stub/StubDownloader.groovy
@@ -81,7 +81,7 @@ class StubDownloader {
         }
 
         private void failureHandler(String stubRepository, String reason, Exception cause) {
-            throw new DependencyResolutionException("Unable to resolve dependency in stub repository [$stubRepository]. Reason: $reason", cause)
+            log.error("Unable to resolve dependency in stub repository [$stubRepository]. Reason: [$reason]", cause)
         }
 
         private void ensureThatLatestVersionWillBePicked(URI resolvedUri) {
@@ -142,10 +142,4 @@ class StubDownloader {
 
     }
 
-    class DependencyResolutionException extends RuntimeException {
-
-        DependencyResolutionException(String message, Throwable cause) {
-            super(message, cause)
-        }
-    }
 }
diff --git a/stub-runner/stub-runner/src/main/groovy/com/ofg/stub/StubRunnerMain.groovy b/stub-runner/stub-runner/src/main/groovy/com/ofg/stub/StubRunnerMain.groovy
@@ -43,11 +43,11 @@ class StubRunnerMain {
     @Option(name = "-ss", aliases = ['--stubsSuffix'], usage = "Suffix for the jar containing stubs (e.g. 'stubs' if the stub jar would have a 'stubs' classifier for stubs: foobar-stubs ). Defaults to 'stubs'")
     private String stubsSuffix = 'stubs'
 
-    @Option(name = "-minp", aliases = ['--minPort'], usage = "Minimal port value to be assigned to the Wiremock instance (e.g. 12345)", required = true)
-    private Integer minPortValue
+    @Option(name = "-minp", aliases = ['--minPort'], usage = "Minimal port value to be assigned to the Wiremock instance. Defaults to 10000")
+    private Integer minPortValue = 10000
 
-    @Option(name = "-maxp", aliases = ['--maxPort'], usage = "Maximum port value to be assigned to the Wiremock instance (e.g. 12345)", required = true)
-    private Integer maxPortValue
+    @Option(name = "-maxp", aliases = ['--maxPort'], usage = "Maximum port value to be assigned to the Wiremock instance. Defaults to 15000")
+    private Integer maxPortValue = 15000
 
     @Option(name = "-s", aliases = ['--skipLocalRepo'], usage = "Switch to check whether local repository check should be skipped and dependencies should be grabbed directly from the net. Defaults to 'false'")
     private Boolean skipLocalRepo