Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats for JSON data files and modules indicate they have dependencies to callbacks even when those callbacks no longer declare them as internal dependencies #84

Closed
jeffschwartz opened this issue Aug 19, 2019 · 0 comments
Closed

stats for JSON data files and modules indicate they have dependencies to callbacks even when those callbacks no longer declare them as internal dependencies #84

jeffschwartz opened this issue Aug 19, 2019 · 0 comments
Assignees
@jeffschwartz
Labels
bug Something isn't working incremental build related Issue is incremental build related
Milestone
v1.1.1

Comments

@jeffschwartz
Copy link
Contributor

jeffschwartz commented Aug 19, 2019 •
edited
Loading

When deleting an internal dependency declaration from a tag-based JavaScript callback, Trio incorrectly copies the old dependency stat over to the new cache file. While it doesn't cause problems the new stats are misleading and it does result in unnecessary generation of pages that do not need to be regenerated.
@jeffschwartz jeffschwartz added bug Something isn't working incremental build related Issue is incremental build related labels Aug 19, 2019
@jeffschwartz jeffschwartz added this to the v1.1.1 milestone Aug 19, 2019
@jeffschwartz jeffschwartz self-assigned this Aug 19, 2019
@jeffschwartz jeffschwartz changed the title stats for deleted tag-based JavaScript callback internal dependencies are copied from the old cache file to the new cache file stats for JSON data files and modules show dependencies to callbacks even when those callbacks no longer declare them as internal dependencies Aug 19, 2019
@jeffschwartz jeffschwartz changed the title stats for JSON data files and modules show dependencies to callbacks even when those callbacks no longer declare them as internal dependencies stats for JSON data files and modules indicate they have dependencies to callbacks even when those callbacks no longer declare them as internal dependencies Aug 20, 2019
jeffschwartz added a commit that referenced this issue Aug 20, 2019
@jeffschwartz
stats for JSON data files and modules now indicate
ec81eed 
that they have no dependencies to callbacks when
those callbacks no longer declare them as internal
dependencies - addresses issue #84
jeffschwartz added a commit that referenced this issue Aug 20, 2019
@jeffschwartz
stats for JSON data files and modules now indicate
149dd84 
that they have no dependencies to callbacks when
those callbacks no longer declare them as internal
dependencies - addresses issue #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffschwartz jeffschwartz

Labels
bug Something isn't working incremental build related Issue is incremental build related
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
1 participant
@jeffschwartz