Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only add beforeunload listener as needed #303

Merged
merged 3 commits into from
Mar 28, 2020
Merged

fix: Only add beforeunload listener as needed #303

merged 3 commits into from
Mar 28, 2020

Conversation

taion
Copy link
Contributor

@taion taion commented Mar 19, 2020

This plays better with the page navigation cache.

See taion/scroll-behavior#344

@taion
fix: Only add the beforeunload listener as needed
9aa9987 
This plays better with the page navigation cache.
@taion taion requested a review from jquense March 19, 2020 00:34
@taion taion changed the title fix: Only add the beforeunload listener as needed fix: Only add beforeunload listener as needed Mar 21, 2020
@taion taion merged commit 250acbd into master Mar 28, 2020
@taion taion deleted the defer-beforeunload branch March 28, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense Awaiting requested review from jquense

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taion