Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning output #57

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

adrianbruntonsagecom
Copy link
Contributor

@adrianbruntonsagecom adrianbruntonsagecom commented Mar 8, 2024

Improves warning output when the plugin could not interpret the code sufficiently to include the file containing the issue.

Before:

[postcss-lit] Skipping template (Line [line]) as it included either invalid syntax or complex expressions the plugin could not interpret. Consider using a "// postcss-lit-disable-next-line" comment to disable this message

After:

[postcss-lit] Skipping template ([path]:[line]) as it included either invalid syntax or complex expressions the plugin could not interpret. Consider using a "// postcss-lit-disable-next-line" comment to disable this message

Copy link
Owner

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. thanks for the contribution!

@43081j
Copy link
Owner

43081j commented Mar 10, 2024

CI is failing presumably because opts.from can be undefined (as can opts)

may be worth just having something like this somewhere:

const errLocation = `${opts?.from ?? 'unknown'}:${node.loc.start.line}` ;

@adrianbruntonsagecom
Copy link
Contributor Author

CI is failing presumably because opts.from can be undefined (as can opts)

may be worth just having something like this somewhere:

const errLocation = `${opts?.from ?? 'unknown'}:${node.loc.start.line}` ;

Thanks - should be sorted now :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8230808334

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.716%

Totals Coverage Status
Change from base Build 7187746188: 0.006%
Covered Lines: 901
Relevant Lines: 909

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8230808334

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.716%

Totals Coverage Status
Change from base Build 7187746188: 0.006%
Covered Lines: 901
Relevant Lines: 909

💛 - Coveralls

@43081j
Copy link
Owner

43081j commented Mar 11, 2024

all looks good now 👍

ill cut a release this weekend if i can

@43081j 43081j merged commit b196730 into 43081j:master Mar 11, 2024
3 checks passed
@adrianbruntonsagecom adrianbruntonsagecom deleted the improve-warning-output branch March 11, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants