fix: unescape backslashes on the way into the parser #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already account for escape sequences added to the AST _later on_
(i.e. something like stylelint, postcss, etc has mutated it).
However, we do not unescape sequences on the way into the parser.
For example:
```ts
css`
.foo {
content: "\\abc";
}
`;
```
This is already escaped, once for JS, once for the resulting CSS.
When we parse this, we extract the CSS _and keep the double-escape_.
This of course means the resulting CSS file internally has one too many
escapes.
To account for this, we now unescape CSS on the way in (i.e. replace
double escapes with single).
Pull Request Test Coverage Report for Build 7159393284
💛 - Coveralls |
adrianbruntonsagecom
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already account for escape sequences added to the AST later on (i.e. something like stylelint, postcss, etc has mutated it).
However, we do not unescape sequences on the way into the parser.
For example:
This is already escaped, once for JS, once for the resulting CSS.
When we parse this, we extract the CSS and keep the double-escape. This of course means the resulting CSS file internally has one too many escapes.
Fixes #51
To account for this, we now unescape CSS on the way in (i.e. replace double escapes with single).