Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to using postcss-js-core #42

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: move to using postcss-js-core #42

wants to merge 7 commits into from

Conversation

43081j
Copy link
Owner

@43081j 43081j commented Dec 23, 2022

Work in progress of the extraction of the core.

It works, tests pass, i just need to move all the tests around a bit and actually publish the repo/package.

then ill probably do a PoC of some other syntax to make sure it covers the right use cases, before merging

Fixes #41

@43081j
Copy link
Owner Author

43081j commented Dec 24, 2022

minor update - just getting all the tests written for the new core, then will publish a pre-release of it and try it out here in this PR.

once that's all working, a pre-release of postcss-lit i think, so i can try it out in the wild.

@coveralls
Copy link

coveralls commented Dec 25, 2022

Pull Request Test Coverage Report for Build 3777392305

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.3%) to 100.0%

Totals Coverage Status
Change from base Build 3622874084: 3.3%
Covered Lines: 305
Relevant Lines: 305

💛 - Coveralls

@43081j
Copy link
Owner Author

43081j commented Dec 25, 2022

have published postcss-lit@next which seems to work! and came across some bugs i fixed while extracting all of this

@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 3776418602

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.3%) to 100.0%

Totals Coverage Status
Change from base Build 3622874084: 3.3%
Covered Lines: 305
Relevant Lines: 305

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the core of postcss-lit to allow other css-in-js syntaxes to be built
2 participants