Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: use [T]::iter() rather than [T]::into_iter() #60

Merged
merged 1 commit into from
Nov 25, 2019
Merged

examples: use [T]::iter() rather than [T]::into_iter() #60

merged 1 commit into from
Nov 25, 2019

Conversation

unleashed
Copy link
Member

@unleashed unleashed commented Nov 25, 2019 •
edited
Loading

Such calls will likely create by-value iterators in the future, and
raise warnings in 1.41.0+.

See issue 66145 in rust-lang/rust.

@unleashed unleashed requested a review from a team November 25, 2019 22:24
@codecov-io
Copy link

codecov-io commented Nov 25, 2019 •
edited
Loading

Codecov Report

Merging #60 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   94.94%   95.12%   +0.18%     
==========================================
  Files          11       11              
  Lines        1008     1006       -2     
==========================================
  Hits          957      957              
+ Misses         51       49       -2
Impacted Files Coverage Δ
tests/api_call.rs 98.98% <0%> (+0.25%) ⬆️
src/lib.rs 100% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc352f...ad1c792. Read the comment docs.

@unleashed
Copy link
Member Author

bors r=@davidor

bors bot added a commit that referenced this pull request Nov 25, 2019
@bors @unleashed
Merge #60
8381d55 
60: examples: use [T]::iter() rather than [T]::into_iter() r=davidor a=unleashed

Such calls will likely create by-value iterators in the future, and
raise warnings in 1.41.0+.

See issue rust-lang/rust#66145.

Co-authored-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
@unleashed unleashed force-pushed the ary-into-iter-to-iter branch from 7f7cf44 to dd45376 Compare November 25, 2019 23:14
@bors
Copy link
Contributor

bors bot commented Nov 25, 2019

Canceled

@unleashed
examples: use [T]::iter() rather than [T]::into_iter()
ad1c792 
Such calls will likely create by-value iterators in the future, and
raise warnings in 1.41.0+.

See issue rust-lang/rust issue 66145.
@unleashed unleashed force-pushed the ary-into-iter-to-iter branch from dd45376 to ad1c792 Compare November 25, 2019 23:19
@unleashed
Copy link
Member Author

bors r=@davidor

bors bot added a commit that referenced this pull request Nov 25, 2019
@bors @unleashed
Merge #60
1476188 
60: examples: use [T]::iter() rather than [T]::into_iter() r=davidor a=unleashed

Such calls will likely create by-value iterators in the future, and
raise warnings in 1.41.0+.

See issue 66145 in rust-lang/rust.

Co-authored-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
@bors
Copy link
Contributor

bors bot commented Nov 25, 2019

Build succeeded

@bors bors bot merged commit ad1c792 into master Nov 25, 2019
@bors bors bot deleted the ary-into-iter-to-iter branch November 25, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidor davidor davidor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unleashed @codecov-io @davidor