-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE -- add feedback #5
Open
dpcairns
wants to merge
32
commits into
3rd-git-from-the-hub:master
Choose a base branch
from
dpcairns:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding end points for getting random planet and spaceship choice
testing put and get methods for user/ship
…ame-backend into dev this merge is important because it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presentation Feedback
* Product talk
* Engaging intro with clean description of the features and intention of the game
* Lucia
* Cool talk on managing global state throughout the app. This is a huge challenge—maybe the primary challenge of app development—and your talk was relatable and lucid
* Awesome breakdown of the relationship between user input and your super-complex game state. It’s not immediately obvious from playing just how much state there is, so it was great that you spent time talking about your strategies for throwing data around the app
* Erik
* Cool breakdown of all those tables. There’s so much state in this game!
* Hunter
* Great talk on the dynamic assignment of classnames for planets. Very cool deep-dive on your animations in THREE js! It’s not easy to stuff non-react libraries into react, and you made it look easy