-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow valid set() calls without a callback to proceed. These were fa… #249
base: master
Are you sure you want to change the base?
Conversation
…ling silently for no reason other than the fact that a callback was not provided.
I will note that the build failures are not with my test/code. I was getting these same failures with a fresh install. |
@3rd-Eden Any updates on this PR? |
@@ -50,7 +50,7 @@ exports.validateArg = function validateArg (args, config) { | |||
break; | |||
|
|||
case Function: | |||
if (toString.call(value) !== '[object Function]') { | |||
if (typeof obj !== "undefined" && toString.call(value) !== '[object Function]') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateArg is supposed to confirm that an argument is a particular type. It seems like a bad place to turn all function arguments into optionals system wide. There must be a better place for this, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ grep -r validateArg *
lib/memcached.js: if (query.validate && !Utils.validateArg(query, this)) {
lib/utils.js:exports.validateArg = function validateArg (args, config) {
"system wide" seems to be this one call inside of "command", so in all cases that I'm aware of, it is the callback. So in all of those cases (globally?), "undefined" is actually a valid value for that argument. Perhaps renaming "validateArg" to "validateCommandArg" would make that clearer if you still feel strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my point is that if it's optional, you may want to check for optionality before calling this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, passed functions are always callbacks, so they should be globally optional. I have been unable to find any place where they are not, so that seems to me that would be writing code support for a case that doesn't exist. I'm not intimately familiar with the module though, so please correct me if you know of one.
If there is one, IMO, simply checking for optionality before the call would require that I then pass a "fake" function to validateArg in order to get it to pass which seems very hacky. If this is absolutely necessary I would add another item to the config called "OptionalFunction" and copy/paste the "Function" code except also allowing undefined, and then globally find/replace Function with OptionalFunction in every command config definition.
But again, unless a case is identified, this seems like code bloat for a situation that doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunavant I understand your case. I'm also not 100% intimately familiar with the entire codebase however.
@3rd-Eden, any input?
This just burned me as well. I agree that the callback should be optional but regardless silent failure isn't the right behavior. |
@ronkorving @3rd-Eden Just FYI, I've been running this in my production services without issues. If you see the posts lots of people keep hitting this bug. If there's anything else I can provide in the pull request please let me know. |
…iling silently for no reason other than the fact that a callback was not provided.
This fixes issue #248