-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port to Godot 4 #11
base: main
Are you sure you want to change the base?
Conversation
Error when trying to run on G4B4 Win11 x64
|
The main branch's Unix code is blocked by the Godot-UnixSocket, which needs to port to GDExtension. It will not work currently. I have opened a Windows branch which removes Unix-related code. If you want to test it out on Windows. https://github.com/edisonlee55/godot-editor-discord-presence/tree/windows |
I have ported Abdera7mane/discord-rpc-gdscript@203f6d5 to Godot 4 and Abdera7mane/Godot-UnixSocket@9e3e106 to GDExtension however MacOS support is lacking. I also took this as an opportunity to rework on the Discord RPC implementation and made it way simpler. Here is an example of rich presence update: var discord := DiscordRPC.new()
# establish a connection and wait for rpc_ready signal
discord.update_presence({
details = "In menu",
state = "AFK",
assets = {
large_image = "icon"
}
}) I still have some things to add before v2 release. |
It would be nice to have this working again. I tested @edisonlee55 's branch and it seems to be working fine (aside from one parameter that needed to be removed) just for Windows, which is just enough for my use-case. Still would be nice to be able to download this from the AssetLib. |
Windows port is done and tested on my side.
Unix-based port is currently blocked by Abdera7mane/Godot-UnixSocket. Need to port it from GDNative to GDExtension.