[IDLE-518] ECR 레파지토리 변경

[mjj111]

1. 📄 Summary

하드코딩된 ECR 레파지토리 변경

5. 📸 스크린샷(선택)

Summary by CodeRabbit

• 인프라 변경
  • GitHub Actions 워크플로우에서 Docker 이미지 리포지토리 이름을 idle-ecr에서 caremeet으로 업데이트
  • 개발 및 프로덕션 서버 배포 프로세스의 SSH 연결 방식 최적화
  • Docker Compose 구성에서 서비스 이미지 소스 변경

[coderabbitai]

워크스루

이 풀 리퀘스트는 GitHub Actions 워크플로우와 Docker Compose 구성 파일의 변경 사항을 포함하고 있습니다. 주요 변경 사항은 Docker 이미지 리포지토리 이름을 idle-ecr에서 caremeet으로 업데이트하는 것입니다. 이는 개발 및 프로덕션 서버 배포 워크플로우와 개발 환경 Docker Compose 파일에 영향을 미칩니다.

변경 사항

파일	변경 요약
.github/workflows/dev-server-integrator.yaml	REPOSITORY 환경 변수를 idle-ecr에서 caremeet으로 변경
.github/workflows/prod-server-deployer.yaml	SSH를 통한 Docker 설치 및 배포 프로세스 통합
idle-presentation/compose-dev.yaml	spring 서비스 이미지를 idle-ecr에서 caremeet으로 변경

관련 가능한 풀 리퀘스트

• [IDLE-000] Redis 볼륨 설정 #172: .github/workflows/dev-server-integrator.yaml의 환경 변수 REPOSITORY 관련 변경 사항

제안된 레이블

🌍인프라

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

.github/workflows/prod-server-deployer.yaml (1)

95-95: 파일 끝에 개행 문자 추가 필요

YAML 파일 포맷팅 규칙에 따라 파일 끝에 개행 문자를 추가해주세요.

🧰 Tools

🪛 yamllint (1.35.1)

[error] 95-95: no new line character at the end of file

(new-line-at-end-of-file)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63bda35 and 886cdba.

📒 Files selected for processing (3)

• .github/workflows/dev-server-integrator.yaml (1 hunks)
• .github/workflows/prod-server-deployer.yaml (1 hunks)
• idle-presentation/compose-dev.yaml (1 hunks)

🧰 Additional context used

🪛 yamllint (1.35.1)

.github/workflows/prod-server-deployer.yaml

[error] 95-95: no new line character at the end of file

(new-line-at-end-of-file)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build and analyze

🔇 Additional comments (2)

idle-presentation/compose-dev.yaml (1)

4-4: ECR 레포지토리 이름 변경 검증 필요

개발 환경의 ECR 레포지토리가 'idle-ecr'에서 'caremeet'으로 변경되었습니다. 이 변경이 로컬 개발 환경에 미치는 영향을 확인해주세요.

✅ Verification successful

ECR 레포지토리 이름 변경 검증 완료

코드베이스 검사 결과, 'idle-ecr'에서 'caremeet'로의 ECR 레포지토리 이름 변경이 compose-dev.yaml 파일에만 국한되어 있습니다. 다른 설정 파일이나 배포 스크립트에는 영향을 미치지 않습니다. 단, 새로운 ECR 레포지토리 설정 방법을 개발 문서에 추가하는 것을 권장드립니다.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# ECR 레포지토리 존재 여부 확인
aws ecr-public describe-repositories --region us-east-1 --repository-names caremeet || echo "Repository does not exist"

Length of output: 240

---

Script:

#!/bin/bash
# Search for ECR repository name references
echo "=== Searching for 'idle-ecr' references ==="
rg "idle-ecr" -l

echo -e "\n=== Searching for 'caremeet' references ==="
rg "caremeet" -l

Length of output: 290

---

Script:

#!/bin/bash
echo "=== README.md content around 'caremeet' mentions ==="
rg "caremeet" README.md -B 2 -A 2

Length of output: 212

.github/workflows/dev-server-integrator.yaml (1)

32-32: CI 파이프라인 레포지토리 설정 변경 확인

개발 서버 CI 파이프라인의 ECR 레포지토리가 'caremeet'으로 변경되었습니다. 이는 compose-dev.yaml의 변경사항과 일치합니다.

팀원들에게 이 변경사항이 공유되었는지 확인해주세요. 특히 로컬 개발 환경에서 이미지를 가져오는 과정에 영향을 줄 수 있습니다.

[coderabbitai]

🛠️ Refactor suggestion

배스천 호스트를 통한 Docker 설치 프로세스 개선 필요

배스천 호스트를 통한 프로덕션 서버 접근 방식이 추가되었습니다. 다음 사항들을 고려해주세요:

1. Docker 설치 스크립트에 버전 지정이 없습니다
2. 설치 실패 시 에러 처리가 없습니다
3. sudo 명령어 실행 권한 확인이 필요합니다

다음과 같이 스크립트를 개선하는 것을 제안드립니다:

- sudo apt-get install -y docker.io
+ DOCKER_VERSION="20.10.24"
+ sudo apt-get install -y docker.io=${DOCKER_VERSION}* || {
+   echo "Docker 설치 실패"
+   exit 1
+ }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	- name: SSH to Bastion and Install Docker if not present on Production server
	uses: appleboy/ssh-action@v1.0.3
	with:
	host: ${{ vars.INSTANCE_HOST }}
	username: ${{ vars.INSTANCE_USERNAME }}
	host: ${{ vars.BASTION_HOST }}
	username: ${{ vars.BASTION_USERNAME }}
	key: ${{ secrets.INSTANCE_PEM_KEY }}
	script: |
	if ! command -v docker >/dev/null 2>&1; then
	echo "Installing Docker..."
	sudo apt-get update
	sudo apt-get install -y docker.io
	else
	echo "Docker already installed."
	fi
	if ! command -v docker-compose >/dev/null 2>&1; then
	echo "Installing Docker Compose..."
	sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
	sudo chmod +x /usr/local/bin/docker-compose
	else
	echo "Docker Compose already installed."
	fi
	- name: Configuration Env file
	uses: appleboy/ssh-action@master
	env:
	VARS_CONTEXT: ${{ toJson(vars) }}
	SECRETS_CONTEXT: ${{ toJson(secrets) }}
	with:
	host: ${{ vars.INSTANCE_HOST }}
	username: ${{ vars.INSTANCE_USERNAME }}
	key: ${{ secrets.INSTANCE_PEM_KEY }}
	envs: VARS_CONTEXT,SECRETS_CONTEXT
	script: |
	cd ~/app/docker
	jq -s '.[0] * .[1] | del(.INSTANCE_PEM_KEY)' <(echo "$VARS_CONTEXT") <(echo "$SECRETS_CONTEXT") \
	| jq -r 'to_entries | map("\(.key)=\(.value)") | .[]' > .env
	ssh -o "ProxyJump=${{ vars.BASTION_HOST }}" -i ${{ secrets.INSTANCE_PEM_KEY }} ${{ vars.INSTANCE_USERNAME }}@${{ vars.INSTANCE_HOST }} << 'EOF'
	if ! command -v docker >/dev/null 2>&1; then
	echo "Installing Docker..."
	sudo apt-get update
	sudo apt-get install -y docker.io
	else
	echo "Docker already installed."
	fi
	if ! command -v docker-compose >/dev/null 2>&1; then
	echo "Installing Docker Compose..."
	sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
	sudo chmod +x /usr/local/bin/docker-compose
	else
	echo "Docker Compose already installed."
	fi
	EOF
	- name: SSH to Bastion and Install Docker if not present on Production server
	uses: appleboy/ssh-action@v1.0.3
	with:
	host: ${{ vars.BASTION_HOST }}
	username: ${{ vars.BASTION_USERNAME }}
	key: ${{ secrets.INSTANCE_PEM_KEY }}
	script: |
	ssh -o "ProxyJump=${{ vars.BASTION_HOST }}" -i ${{ secrets.INSTANCE_PEM_KEY }} ${{ vars.INSTANCE_USERNAME }}@${{ vars.INSTANCE_HOST }} << 'EOF'
	if ! command -v docker >/dev/null 2>&1; then
	echo "Installing Docker..."
	sudo apt-get update
	DOCKER_VERSION="20.10.24"
	sudo apt-get install -y docker.io=${DOCKER_VERSION}* || {
	echo "Docker 설치 실패"
	exit 1
	}
	else
	echo "Docker already installed."
	fi
	if ! command -v docker-compose >/dev/null 2>&1; then
	echo "Installing Docker Compose..."
	sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
	sudo chmod +x /usr/local/bin/docker-compose
	else
	echo "Docker Compose already installed."
	fi
	EOF

[coderabbitai]

⚠️ Potential issue

프로덕션 배포 프로세스 보안 강화 필요

프로덕션 배포 과정에서 몇 가지 보안 관련 우려사항이 있습니다:

1. Docker 로그인 정보가 로그에 노출될 수 있습니다
2. 컨테이너 이름이 하드코딩되어 있습니다
3. 이전 컨테이너 제거 실패 시 에러 처리가 없습니다

다음과 같은 개선을 제안드립니다:

- sudo docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_PASSWORD }}
+ echo "${{ secrets.DOCKER_PASSWORD }}" | sudo docker login --username ${{ secrets.DOCKER_USERNAME }} --password-stdin

- if [ $(sudo docker ps -q -f name=caremeet_server_prod) ]; then
+ CONTAINER_NAME="caremeet_server_prod"
+ if [ $(sudo docker ps -q -f name=${CONTAINER_NAME}) ]; then
+   echo "기존 컨테이너 제거 중..."
+   sudo docker stop ${CONTAINER_NAME} || { echo "컨테이너 중지 실패"; exit 1; }
+   sudo docker rm ${CONTAINER_NAME} || { echo "컨테이너 제거 실패"; exit 1; }
+ fi

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	- name: SSH to Bastion and deploy to Production server
	uses: appleboy/ssh-action@master
	with:
	host: ${{ vars.INSTANCE_HOST }}
	username: ${{ vars.INSTANCE_USERNAME }}
	host: ${{ vars.BASTION_HOST }}
	username: ${{ vars.BASTION_USERNAME }}
	key: ${{ secrets.INSTANCE_PEM_KEY }}
	script: |
	ssh -o "ProxyJump=${{ vars.BASTION_HOST }}" -i ${{ secrets.INSTANCE_PEM_KEY }} ${{ vars.INSTANCE_USERNAME }}@${{ vars.INSTANCE_HOST }} << 'EOF'
	sudo docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_PASSWORD }}
	sudo docker pull public.ecr.aws/f5q3r6m5/idle-prod-ecr:$IMAGE_TAG
	if [ $(sudo docker ps -q -f name=caremeet_server_prod) ]; then
	sudo docker stop caremeet_server_prod
	sudo docker rm caremeet_server_prod
	sudo docker stop caremeet_server_prod
	sudo docker rm caremeet_server_prod
	fi
	sudo docker run --name caremeet_server_prod --env-file ./app/docker/.env \
	-e SPRING_PROFILES_ACTIVE=prod \
	-d -p 8080:8080 public.ecr.aws/f5q3r6m5/idle-prod-ecr:$IMAGE_TAG
	EOF
	- name: SSH to Bastion and deploy to Production server
	uses: appleboy/ssh-action@master
	with:
	host: ${{ vars.BASTION_HOST }}
	username: ${{ vars.BASTION_USERNAME }}
	key: ${{ secrets.INSTANCE_PEM_KEY }}
	script: |
	ssh -o "ProxyJump=${{ vars.BASTION_HOST }}" -i ${{ secrets.INSTANCE_PEM_KEY }} ${{ vars.INSTANCE_USERNAME }}@${{ vars.INSTANCE_HOST }} << 'EOF'
	echo "${{ secrets.DOCKER_PASSWORD }}" | sudo docker login --username ${{ secrets.DOCKER_USERNAME }} --password-stdin
	sudo docker pull public.ecr.aws/f5q3r6m5/idle-prod-ecr:$IMAGE_TAG
	CONTAINER_NAME="caremeet_server_prod"
	if [ $(sudo docker ps -q -f name=${CONTAINER_NAME}) ]; then
	echo "기존 컨테이너 제거 중..."
	sudo docker stop ${CONTAINER_NAME} || { echo "컨테이너 중지 실패"; exit 1; }
	sudo docker rm ${CONTAINER_NAME} || { echo "컨테이너 제거 실패"; exit 1; }
	fi
	sudo docker run --name caremeet_server_prod --env-file ./app/docker/.env \
	-e SPRING_PROFILES_ACTIVE=prod \
	-d -p 8080:8080 public.ecr.aws/f5q3r6m5/idle-prod-ecr:$IMAGE_TAG
	EOF