Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDLE-400] 채용 공고 지원자 발생 시, 센터 관리자에게 알림을 발송한다. #183
[IDLE-400] 채용 공고 지원자 발생 시, 센터 관리자에게 알림을 발송한다. #183
Changes from all commits
df01ceb
942374a
03c319e
e405542
0f84a00
8257e43
0f88be5
6f185c2
eaa9122
83d0c69
bd9ce68
6d967a9
33c1a79
4bfe1a4
e4b9ede
6bdf1bf
d3ef466
452723a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Null 안전성 개선 및 오류 로깅 추가 제안
centerManagers
가 null일 경우를 처리하지 않고 있습니다. 또한, 알림 발송 과정에서 발생할 수 있는 예외 처리가 없습니다. 다음과 같은 개선을 제안합니다:이러한 변경으로 코드의 안정성과 디버깅 용이성이 향상될 것입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notification 생성 시 필드 검증 로직 추가 필요
notificationInfo
의 필드 값에 대한 유효성 검사가 이루어지지 않고 있습니다. 중요한 필드에 대한 Null 체크나 형식 검증 등을 추가하여 데이터 무결성을 확보하는 것이 좋습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
'limit' 파라미터에 대한 유효성 검사 추가 권장
limit
값이 비정상적으로 큰 경우 시스템 성능에 영향이 있을 수 있습니다. 최대 허용 범위를 설정하고 이에 대한 유효성 검사를 추가하여 안전성을 강화하는 것이 좋습니다.