Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDLE-000] TimeZone 설정 제거 #163

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[IDLE-000] TimeZone 설정 제거 #163

merged 1 commit into from
Sep 20, 2024

Conversation

wonjunYou
Copy link
Contributor

@wonjunYou wonjunYou commented Sep 20, 2024

1. 📄 Summary

  • cron scheduler의 timezone 설정을 제거하였습니다.

Summary by CodeRabbit

  • 버그 수정
    • 크론 표현식에서 시간대 속성을 제거하여 서버의 로컬 시간대에 따라 작업이 예약되도록 수정되었습니다.

@wonjunYou wonjunYou added 🚨긴급 신속한 처리가 필요한 이슈 🛠️버그 버그 제보 및 해결 labels Sep 20, 2024
@wonjunYou wonjunYou self-assigned this Sep 20, 2024
@wonjunYou wonjunYou merged commit 60e98e5 into develop Sep 20, 2024
2 of 3 checks passed
Copy link

coderabbitai bot commented Sep 20, 2024

Warning

Rate limit exceeded

@wonjunYou has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 5 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 52b36d2 and 119601d.

Walkthrough

이 변경 사항은 CrawlingJobScheduler.kt 파일에서 scheduleJob 함수에 적용된 @Scheduled 주석의 수정과 관련이 있습니다. 주석의 크론 표현식에서 "KST"로 지정된 시간대 속성이 제거되어, 이제 크론 표현식이 서버의 로컬 시간대로 기본 설정됩니다.

Changes

파일 경로 변경 요약
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt scheduleJob 메서드의 @Scheduled 주석에서 zone 속성이 제거됨. 크론 표현식이 @Scheduled(cron = "0 00 01 * * *")로 변경됨.

Possibly related PRs

Suggested labels

🎯리팩토링


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wonjunYou wonjunYou deleted the fix/IDLE-000 branch September 20, 2024 12:21
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨긴급 신속한 처리가 필요한 이슈 🛠️버그 버그 제보 및 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant