feat: remember monitor name instead of number #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents monitor num mismatch when the number changes. for example when main display is switched around in a multi-display set up
|
What if you have multiple monitors of the same model with the same String name? |
that a good question. ig in this quick implementation i wrote it only saves the name, so the first one (either the one as the main monitor or the one on the left will be selected i think) i fix would be to store something unique to the monitor, if there's any unique id that can be used. otherwise it would have to append a number to that monitor. maybe i could try this by putting my single monitor into split screen mode and connect it as 2 monitors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents a mismatch when the monitor number changes. for example when main display is switched around in a multi-display set up
just an idea