Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix list table primary key #1209

Merged
merged 3 commits into from
Jan 14, 2022
Merged

fix list table primary key #1209

merged 3 commits into from
Jan 14, 2022

Conversation

bysomeone
Copy link
Collaborator

fix #1203

  • 修复table ListPrimary, prefix和primary参数拼接重叠问题

  • 修复table ListPrimary, prefix不生效问题

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1209 (96d7aed) into master (087cdaa) will increase coverage by 0.00%.
The diff coverage is 92.85%.

❗ Current head 96d7aed differs from pull request most recent head 370b58f. Consider uploading reports for the commit 370b58f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   62.51%   62.52%           
=======================================
  Files         164      164           
  Lines       23036    23031    -5     
=======================================
- Hits        14401    14399    -2     
+ Misses       6817     6813    -4     
- Partials     1818     1819    +1     
Impacted Files Coverage Δ
common/db/table/query.go 75.30% <92.85%> (+4.37%) ⬆️
system/crypto/secp256r1/utils.go 71.01% <0.00%> (-2.90%) ⬇️
system/p2p/dht/protocol/broadcast/pubsub.go 69.82% <0.00%> (-1.73%) ⬇️
common/skiplist/skiplist.go 70.06% <0.00%> (-1.28%) ⬇️
blockchain/process.go 55.04% <0.00%> (-0.87%) ⬇️
blockchain/blockstore.go 62.24% <0.00%> (-0.20%) ⬇️
rpc/jrpchandler.go 67.09% <0.00%> (-0.19%) ⬇️
queue/queue.go 73.19% <0.00%> (+1.03%) ⬆️
common/db/table/table.go 62.75% <0.00%> (+1.14%) ⬆️
system/p2p/dht/extension/pubsub.go 77.77% <0.00%> (+1.38%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf2911...370b58f. Read the comment docs.

@bysomeone bysomeone changed the title WIP fix list table primary key fix list table primary key Jan 13, 2022
vipwzw
vipwzw previously approved these changes Jan 13, 2022
@vipwzw vipwzw self-requested a review January 14, 2022 03:21
@vipwzw vipwzw dismissed their stale review January 14, 2022 03:22

还需要研究一下这个问题

@vipwzw vipwzw merged commit 759903f into 33cn:master Jan 14, 2022
@33cn
Copy link
Owner

33cn commented Jan 14, 2022

🎉 This PR is included in version 1.66.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@33cn 33cn added the released label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localdb 删除key存在问题
3 participants