Generic analytics: fix spurious warning messages (prebid#10739)

33Across · Nov 30, 2023 · a8fedc6 · a8fedc6
1 parent 9c597a3
commit a8fedc6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/modules/genericAnalyticsAdapter.js b/modules/genericAnalyticsAdapter.js
@@ -1,6 +1,6 @@
 import AnalyticsAdapter from '../libraries/analyticsAdapter/AnalyticsAdapter.js';
 import {prefixLog, isPlainObject} from '../src/utils.js';
-import * as CONSTANTS from '../src/constants.json';
+import {has as hasEvent} from '../src/events.js';
 import adapterManager from '../src/adapterManager.js';
 import {ajaxBuilder} from '../src/ajax.js';
 
@@ -48,12 +48,12 @@ export function GenericAnalytics() {
         return false;
       }
       for (const [event, handler] of Object.entries(options.events)) {
-        if (!CONSTANTS.EVENTS.hasOwnProperty(event)) {
+        if (!hasEvent(event)) {
           logWarn(`options.events.${event} does not match any known Prebid event`);
-          if (typeof handler !== 'function') {
-            logError(`options.events.${event} must be a function`);
-            return false;
-          }
+        }
+        if (typeof handler !== 'function') {
+          logError(`options.events.${event} must be a function`);
+          return false;
         }
       }
     }

diff --git a/src/events.js b/src/events.js
@@ -89,6 +89,8 @@ const _public = (function () {
     return allEvents.includes(event)
   }
 
+  _public.has = _checkAvailableEvent;
+
   _public.on = function (eventString, handler, id) {
     // check whether available event or not
     if (_checkAvailableEvent(eventString)) {
@@ -163,7 +165,7 @@ const _public = (function () {
 
 utils._setEventEmitter(_public.emit.bind(_public));
 
-export const {on, off, get, getEvents, emit, addEvents} = _public;
+export const {on, off, get, getEvents, emit, addEvents, has} = _public;
 
 export function clearEvents() {
   eventsFired.clear();

diff --git a/test/spec/modules/genericAnalyticsAdapter_spec.js b/test/spec/modules/genericAnalyticsAdapter_spec.js
@@ -75,7 +75,7 @@ describe('Generic analytics', () => {
             options: {
               url: 'mock',
               events: {
-                bidResponse: null
+                mockEvent: null
               }
             }
           });