Type check

2tvenom · Mar 16, 2014 · c2959e5 · c2959e5
1 parent efec77f
commit c2959e5
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/cbor/cbor.go b/src/cbor/cbor.go
@@ -290,16 +290,25 @@ func (encoder *cborEncode) decode(v reflect.Value) (bool, error) {
 		case majorTypeSimpleAndFloat:
 			switch headerAdditionInfo {
 			case additionalTypeIntFalse:
+				if v.Kind() != reflect.Bool {
+					return false, fmt.Errorf("Can convert %s to bool", v.Type())
+				}
 				v.Set(reflect.ValueOf(false))
 				return true, nil
 			case additionalTypeIntTrue:
+				if v.Kind() != reflect.Bool {
+					return false, fmt.Errorf("Can convert %s to bool", v.Type())
+				}
 				v.Set(reflect.ValueOf(true))
 				return true, nil
 			case additionalTypeIntNull:
 				return true, nil
 			case additionalTypeFloat16:
 				return true, fmt.Errorf("Float16 decode not support")
 			case additionalTypeFloat32:
+				if v.Kind() != reflect.Float32 {
+					return false, fmt.Errorf("Can convert %s to float32", v.Type())
+				}
 				var out float32
 				err := unpack(buff, &out)
 
@@ -311,7 +320,11 @@ func (encoder *cborEncode) decode(v reflect.Value) (bool, error) {
 
 				return true, nil
 			case additionalTypeFloat64:
+				if v.Kind() != reflect.Float64 {
+					return false, fmt.Errorf("Can convert %s to float64", v.Type())
+				}
 				var out float64
+
 				err := unpack(buff, &out)
 
 				if err != nil {