-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pangeo/pangeo-notebook as base image #15
Conversation
Curated upstream image! But it doesn't have R, so we add it. Our environment.yml file only adds packages that aren't in the base image. Ref #3
f270fce
to
f070c29
Compare
6e0898d
to
fb0e642
Compare
Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>
b364493
to
22a8534
Compare
Is there anything holding this one back? Checks seem green, no comments on things to resolve? |
Hey @choldgraf! This is already deployed on the staging hubs. We just need to wait a little so that folks test it a bit to make sure everything works before deploying it to prod. |
Ah right - do the folks that should be testing it know that they need to test it out? |
Yep! It's on the Gitter chat. |
0957682
to
9363681
Compare
Deployed on prod 🎉 |
Fantastic, thanks so much for this integration! Going forward, 2i2c folks should feel free to engage on https://github.com/pangeo-data/pangeo-docker-images/ when it comes to updating this image. Many of the changes here could be pushed upstream. In the long term, we need to find a way to make updates to the pangeo environments less dependent on support from the admins. This image has a lot of churn, since we always need to be on the bleeding edge of the many package releases. I notice we are pinning to a particular commit, but the pangeo-notebook image is often updated several times a week. So this will be stale in a few weeks. |
Curated upstream image! But it doesn't have R, so we
add it. Our environment.yml file only adds packages that
aren't in the base image.
Ref #3
Closes #19
Closes #22