Focus table #46
Merged
Focus table #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlgo11 <Carlgo11@users.noreply.github.com>
phallobst
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #37 and a recent Slack conversation.
Currently, the category button is focused on when opening a category. This is to not break the spacial awareness of the user.
This pull request moves the focus to the actual table and using JavaScript focuses on the category button.
The end result is visually nearly identical whilst at the same time allowing screen readers to focus on the actually desired content.
I also added
<section>elements to better structure the content and allow for skipping unwanted data with a screen reader.