fix: bookmarks not showing up when request fails #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are simplifying the implementation to no longer guess the description based on the contents of the page. Doing that does work when the page has paragraphs but for customized layouts there are no grantees. Defaulting to showing title and URL when no meta tags are present is consistent with how Notion does it. Closes: #555 \#555: Bookmarks not working when using multiple bookmarks
a1590a4 to
8b3c000
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are simplifying the implementation to no longer guess the description
based on the contents of the page. Doing that does work when the page
has paragraphs but for customized layouts there are no grantees.
Defaulting to showing title and URL when no meta tags are present is
consistent with how Notion does it.
Closes: #555
#555: Bookmarks not working when using multiple bookmarks