Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: restructure routes based on their usage #570

Merged
merged 28 commits into from
Apr 10, 2022
Merged

refactor: restructure routes based on their usage #570

merged 28 commits into from
Apr 10, 2022

Conversation

aalemayhu
Copy link
Contributor

Continuing on #549

aalemayhu added 21 commits April 9, 2022 17:33
@aalemayhu
refactor: restructure routes based on their usage
40d33bc 
This is cleaner.
@aalemayhu
refactor: don't use use controlled data for the query
d8b9f3e
@aalemayhu
fix: Revert "refactor: don't use use controlled data for the query"
ba09ea9 
This reverts commit 68114be.
@aalemayhu
refactor: try to fix sonarcloud errors
fe0e42d
@aalemayhu
fix: Revert "refactor: try to fix sonarcloud errors"
c2cc858 
This reverts commit 9a9d424.
@aalemayhu
refactor: try moving fields into own object
3497ade
@aalemayhu
refactor: clean up all of the workflow files
fcbf46c 
Close: #538
@aalemayhu
refactor: use lots of small helper functions instead of class
0118ad8 
Looks cleaner.
@aalemayhu
refactor: remove the user class
437a987
@aalemayhu
refactor: reduce code smells
dc079c9
@aalemayhu
refactor: split up the upload endpoints
b3f3573
@aalemayhu
chore: update script for linting
8c0967b
@aalemayhu
style: run eslint --fix [...] on server
0ce05ff
@aalemayhu
refactor: slim down the upload handler
aee59de
@aalemayhu
style: remove todo comments from the whole codebase
02a7ed7
@aalemayhu
refactor: reorganize code to reduce code smells
183490e
@aalemayhu
refactor: remove more code smells
dade483
@aalemayhu
refactor: more code smellm
04d07a0
@aalemayhu
chore: fix build issues
0828b54
@aalemayhu
refactor: remove duplicate lines
19d6907
@aalemayhu
refactor: fix more code smells
a1041ad
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 16 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aalemayhu aalemayhu merged commit 74a7640 into main Apr 10, 2022
@aalemayhu aalemayhu deleted the pr/aalemayhu/549 branch April 10, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aalemayhu