Merge pull request #493 from alemayhu/fix-webpack-sonar-issue

refactor: use conditional statement instead of switch
2anki · Mar 5, 2022 · 10bc9fd · 10bc9fd
2 parents 655df43 + 2d3de89
commit 10bc9fd
Showing 1 changed file with 18 additions and 22 deletions.
diff --git a/web/config-overrides.js b/web/config-overrides.js
@@ -1,27 +1,23 @@
 /* config-overrides.js */
-const MonacoWebpackPlugin = require('monaco-editor-webpack-plugin');
-
+const MonacoWebpackPlugin = require("monaco-editor-webpack-plugin");
 
 module.exports = function override(config) {
-        if (!config.plugins) {
-                config.plugins = [];
-        }
-        config.plugins.push(
-                new MonacoWebpackPlugin()
-        );
-        switch (process.env.NODE_ENV) {
-                case 'production':
-                        config.plugins = config.plugins.filter(plugin => {
-                                return plugin.constructor.name !== 'ForkTsCheckerWebpackPlugin';
-                        });
-                        return config;
-                default:
-                        let forkTsCheckerWebpackPlugin = config.plugins.find(plugin => {
-                                return plugin.constructor.name === 'ForkTsCheckerWebpackPlugin';
-                        });
-                        forkTsCheckerWebpackPlugin.memoryLimit = 4096;
-                        return config;
-        }
+  if (!config.plugins) {
+    config.plugins = [];
+  }
+  config.plugins.push(new MonacoWebpackPlugin());
+  if (process.env.NODE_ENV === "production") {
+    config.plugins = config.plugins.filter((plugin) => {
+      return plugin.constructor.name !== "ForkTsCheckerWebpackPlugin";
+    });
+    return config;
+  }
+
+  let forkTsCheckerWebpackPlugin = config.plugins.find((plugin) => {
+    return plugin.constructor.name === "ForkTsCheckerWebpackPlugin";
+  });
+  forkTsCheckerWebpackPlugin.memoryLimit = 4096;
+  return config;
 };
 // Ref https://github.com/microsoft/monaco-editor/issues/82
-// Ref https://www.gitmemory.com/issue/facebook/create-react-app/7135/497102755
+// Ref https://www.gitmemory.com/issue/facebook/create-react-app/7135/497102755