Skip to content

Commit

Permalink
fix building TWRP for devices without cache
Browse files Browse the repository at this point in the history
Some devices do not declare BOARD_CACHEIMAGE_PARTITION_SIZE.
This case is detected and required modules are added to LOCAL_REQUIRED_MODULES.
However, := is used instead of +=  and causes the loss of all previously added modules.
The end result is that twrp is not actually getting built since its module was lost.
Fix that by using += when adding modules required for cache-less devices.

Change-Id: Ib0a4db4955040ced77be7ed04d636905beadf093
  • Loading branch information
oshmoun authored and Dees-Troy committed Mar 18, 2019
1 parent 5f8394c commit 9220dba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ ifeq ($(shell test $(PLATFORM_SDK_VERSION) -ge 25; echo $$?),0)
endif

ifeq ($(BOARD_CACHEIMAGE_PARTITION_SIZE),)
LOCAL_REQUIRED_MODULES := recovery-persist recovery-refresh
LOCAL_REQUIRED_MODULES += recovery-persist recovery-refresh
endif

include $(BUILD_EXECUTABLE)
Expand Down

0 comments on commit 9220dba

Please sign in to comment.