Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Set allowed WebSocket frame size to 100MB #2

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Conversation

onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Aug 1, 2019

It seems that some blocks are too big to transfer over WebSocket using Web3.js's default frame size, which leads to "disconnections" (also known as very bad error messages). This is a fix for #1.

Reference: web3/web3.js#1217

@onbjerg onbjerg added the bug Something isn't working label Aug 1, 2019
@onbjerg onbjerg marked this pull request as ready for review August 1, 2019 20:04
@onbjerg onbjerg changed the title Set allowed WebSocket frame size to a high number Set allowed WebSocket frame size to 100MB Aug 1, 2019
Copy link
Member

@lkngtn lkngtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and thanks!

@lkngtn lkngtn merged commit 54a348c into master Aug 1, 2019
@lkngtn lkngtn mentioned this pull request Aug 1, 2019
@onbjerg onbjerg deleted the disconnection-fix branch August 1, 2019 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants