Remove google-analytics.com from the egress proxy allow list #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2024 17:10
This change needs to be manually deployed to the egress proxy applications for staging and production.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 66 66
Lines 4177 4177
=======================================
Hits 3934 3934
Misses 243 243 ☔ View full report in Codecov by Sentry. |
cantsin
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
google-analytics.comfrom the egress proxy allow list. @cantsin and I haven't found any reason that we would be sending data there from Tock's server side, and I've applied that update in staging without issue.This PR also tidies up some small omissions in the egress proxy deployment docs.
This follows up work for #1792.
Deployment
After merge, I will apply the egress proxy config change in production following these docs.
This PR doesn't include any changes in the deployed Tock application code, so there's no need for an immediate production release.