Refactor React object memoization using custom hook #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: - More concise - Less error-prone in case of forgotten dependency key - May encourage memoization of objects when appropriate, by making it less tedious to accomplish changelog: Internal, Performance, Create helper utility for front-end object memoization
See: #6363 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
6bfcaf5 to
2bb9dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The original idea with this pattern is to try to avoid unnecessary renders of context consumers, where object context values would always be strictly unequal between renders unless memoized (
{} !== {}). However, when trying to find some resources justifying the pattern, I found more resources in favor of avoiding "premature" memoization, or finding alternative ways to reduce re-renders ([1][2][3]). That being said, I still think there is some value in the memoization, and at least the first two points of the list above provide value for existing usage.