resolves #4, resolves #9, resolves #10, resolves #11 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-b180
reviewed
Jan 4, 2021
| @@ -3,7 +3,7 @@ apply plugin: 'net.corda.plugins.cordapp' | |||
|
|
|||
| cordapp { | |||
| targetPlatformVersion 7 | |||
| minimumPlatformVersion 7 | |||
| minimumPlatformVersion 6 | |||
There was a problem hiding this comment.
Worth adding a comment explaining why it's the minimum version
There was a problem hiding this comment.
Updated commit message
| @@ -208,6 +209,27 @@ class JavaInstantSerializer : CustomSerializer<Instant>, | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Serializer for an [Duration] representing it as a JSON string value formatted as an ISO-8601 timestamp. | |||
There was a problem hiding this comment.
Misleading comment about 'timestamp', it's actually ISO duration format
| override fun generateSchema(generator: JsonSchemaGenerator): JsonObject { | ||
| return mapOf( | ||
| "type" to "string", | ||
| "format" to "date-time" |
There was a problem hiding this comment.
The format is not date-time, but ISO duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for various issues based on testing with obligation cordapp
Change summary: