Ripping series only outputting one file

[GamerBene19]

• I have checked the wiki
• I have searched for similar issues

Describe the bug
When ripping a series only one file is put into the output directory

Expected result
I would expect all episodes of a series to be present with name something like Sample Series (1972) - Episode 1.mkv

To Reproduce

1. Set method to mkv (I have it set to that, but don't think its relevant here)
2. Rip disc containing multiple episodes of a series
3. Observe all episodes beeing put into raw but only one (I think the first) beeing put into completed

Environment

Ubuntu 20.04.4, on commit 8d32bab757f090d474d85c579037021771d19fec of branch v2_devel

Log file (cut to relevant section at the end)

Sample Series_DISC1.log

[1337-server]

Reopened as it needs testing fully, but this should fix the issue.

[GamerBene19]

as it needs testing fully

How would I do that? Do just I update my existing install? If so: How?

[1337-server]

Yes its just a small update to your install.
This tells you how to update.
https://github.com/automatic-ripping-machine/automatic-ripping-machine/wiki/upgrading

[GamerBene19]

I've tried out the changes. They don't seem to work. I don't get any files output anymore (could also be because of the other changes made since install though).

Here's the relevant log section again
Sample Series.log

As far as I can tell it tries to move the files from my transcode directory. But there are no files there as I skip transcoding. Note that the log also does not say anything about skipping transcoding anymore.

Edit: It seems like ripping movies fails for the same reason.

[1337-server]

Ok, I think I got it. I'm going to test a bit more before I push, but I've narrowed it down to this line.

automatic-ripping-machine/arm/ripper/arm_ripper.py

Line 73 in 4950530

move_files_post(hb_out_path, job)

It pushes the out_path into move files, but if transcoding is skipped, in_path should be used. As out_path (TRANSCODE_PATH) will be empty.

I'll update when I have fully tested a fix.

[GamerBene19]

My initial issue is solved (all episodes of a series are copied to the output directory). However when a movie now has more than one file. The largest one is beeing left in the extras dir as title_t<number> instead of being copied (and renamded to <movie title> (<year>).mkv in the folder above extras.

[1337-server]

This should finally fix it, let me know if not.

[GamerBene19]

Thanks for the quick fix. Sadly I won't be able to test this till at least friday. I'll give you an update then!

[1337-server]

No worries, there is no rush.

[GamerBene19]

I just tested a movie (with the current version). It seems to work. I will test series shortly but I expect them to work too

However I've noticed something different. Before I could change the title during ripping and the output would get placed into the folder with the new title (the old folder that was created at the beginning still existed, but you could just delete it afterwards). Now, if I don't update the title before the ripping begins the file will not be placed into a folder with the new name.

[1337-server]

It should now update if you set a custom title, or update title from search

[GamerBene19]

So after a bit of testing this weekend I think this issue can be closed. Series are ripped as expected and other behaviour is the same (again)