-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/setup cypress for e2e testing #179
Conversation
@barneyjeffries Thanks a lot for the PR. @jeffpaul could you please help with adding Azure credentials to GH action secrets to the repo? I tried running tests locally and it seems working fine. Thanks. |
@iamdharmesh I've added what I believe are the necessary secrets, but please let me know if anything isn't acting as expected and I'll research further... thanks! |
@iamdharmesh bumping this back up to see if the repo secrets allow this to function as you'd expect? |
@jeffpaul Thanks for adding repo secrets. it's working fine after some minor yml file changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @barneyjeffries, LGTM 🚀
Description of the Change
This PR adds Cypress for e2e testing, configured and with 2 tests set-up:
NOTE: We need to add the test azure account credentials to the GitHub repo but I don't have permissions to do this. The constants should be set as:
MICROSOFT_AZURE_ACCOUNT_NAME
MICROSOFT_AZURE_ACCOUNT_KEY
MICROSOFT_AZURE_CONTAINER
Closes #154
How to test the Change
CYPRESS_MICROSOFT_AZURE_ACCOUNT_NAME=[accountname] CYPRESS_MICROSOFT_AZURE_ACCOUNT_KEY=[key] CYPRESS_MICROSOFT_AZURE_CONTAINER=[container] npm run cypress:open
Changelog Entry
Credits
Checklist: