Feature/maybe hide settings section header #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "Restrict site access to visitors who are logged in or allowed by IP address" is unselected on the "Reading Settings" admin page, the plugin hides the "Handle restricted visitors" and "Unrestricted IP addresses". The "Restricted Site Access" header however remains visible and confusingly looms over whatever settings come after it. This update also hides the "Restricted Site Access" settings page header when the "Restrict site access to visitors who are logged in or allowed by IP address" is unselected.
The settings.min.js script is created in, and loaded from the assets/js/build folder.
Sidsector9
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Thanks for working on this @barryceelen , tested well for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When the "Restrict site access to visitors who are logged in or allowed by IP address" is unselected on the "Reading Settings" admin page, the plugin hides the "Handle restricted visitors" and "Unrestricted IP addresses". The "Restricted Site Access" header however remains visible and confusingly looms over whatever settings come after it.
This update also hides the "Restricted Site Access" settings page header when the "Restrict site access to visitors who are logged in or allowed by IP address" is unselected.
Somewhat unrelated, this update also removes the unused
/assets/js/settings.min.jsfile. This file seems no longer in use: asettings.min.jsfile is now created in and loaded from the/buildfolder.